ref(logs): Change documentation for logs sentry.origin consolidation#15127
Merged
alexsohn1126 merged 7 commits intomasterfrom Oct 9, 2025
Merged
ref(logs): Change documentation for logs sentry.origin consolidation#15127alexsohn1126 merged 7 commits intomasterfrom
sentry.origin consolidation#15127alexsohn1126 merged 7 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AbhiPrasad
reviewed
Oct 3, 2025
bruno-garcia
reviewed
Oct 3, 2025
Co-authored-by: Bruno Garcia <[email protected]>
AbhiPrasad
approved these changes
Oct 3, 2025
Member
Author
|
I'll leave this PR up until Monday morning (EST) to let Vienna employees review this change before merging and telling people to change their SDKs |
…tomatically emitted logs origin
Member
Author
|
Hey @philipphofmann, could you take another look at this? 🙏 |
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Sorry for the late review @alexsohn1126. Thanks for improving this. LGTM with one minor comment.
Co-authored-by: Philipp Hofmann <[email protected]>
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
This was referenced Oct 9, 2025
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
This PR aims to consolidate category in
sentry.originfor Logs.Specifically, I propose we use
auto.log[...]insentry.originfor logs that are generated in logging libraries.I had a discussion regarding what
sentry.originshould be set to insentry-dotnet.We found examples that put different categories for sentry.origin:
auto.log.[...]
auto.log.logcatauto.log.log4j2auto.logger.[...]
auto.logger.loguruauto.logging.[...]
auto.logging.pinolog,logger,loggingdoes not appear in the list of span operations. I do see that we "[...] are free to choose actions and identifiers that best match the use case they are instrumenting".@AbhiPrasad mentioned that:
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES