Updated dotnet options to include all defaults#15218
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@bitsandfoxes - I made some guesses and approximations to defaults based on other SDKs. Please correct where it's wrong. Thanks! ❓ |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
| <PlatformSection supported={["dotnet.xamarin"]}> | ||
|
|
||
| <SdkOption name="ScreenshotQuality" type="enum"> | ||
| <SdkOption name="ScreenshotQuality" type="enum" defaultValue="high"> |
There was a problem hiding this comment.
This must have slipped through, I can't find ScreenshotQuality in neither the .NET SDK nor its Xamarin flavor.
There was a problem hiding this comment.
ScreenshotQuality is weird. It seems like there are mentions of it in this sentry-xamarin pull request: getsentry/sentry-xamarin#76 (comment)
But Don't see it mentioned anywhere in the code itself...
There was a problem hiding this comment.
Hm. Sounds like maybe we remove it then?
There was a problem hiding this comment.
I would say yes, @bitsandfoxes Should we remove this?
Co-authored-by: Stefan Jandl <[email protected]>
Bug: Case Mismatch in StackTraceMode Default ValueThe |
…s-examples * origin/master: (478 commits) docs(godot): Structured logging (#15287) fix(batch-processor): Don't enforce starting timer (#15309) feat(node): Add new options to nativeNodeFetchIntegration (#15282) Updated dotnet options to include all defaults (#15218) ref: add docs that logs channel is optional (#15172) docs(svelteKit): Update build-time options for source maps (#15283) fix(python): Fix paragraph order in Strawberry docs (#15301) Added docs explaining how to disable Sentry Native in the .NET SDK (#15293) Updated Unity options with missing defaults (#15219) docs(otlp): Update docs for client SDK w3c traceparent support (#15294) Adding defaults for Godot options (#15216) feat(crons): Document broken monitors feature (#15280) fix: Remove OTLP logs from EA list (#15288) Bump API schema to 06047b60 (#15276) ref(nextjs): Move manual instrumentation examples for ai into Edge section (#15284) docs(otlp): change status to open beta (#15285) Hono runtime and middleware doc updates (#14853) feat(logs): Clarify API for Hub/Scope and Client (#15281) docs(astro/nuxt): Remove `sourceMapsUploadOptions` option nesting (#14905) docs(profiling): Add docs for Profiling API (#15258) ...
3 participants
DESCRIBE YOUR PR
Updated options with defaults based on move to SDKoption formatting.
Preview: https://sentry-docs-git-dotnet-options-updates.sentry.dev/platforms/dotnet/configuration/options/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES