Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 270.41kB (1.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
JPeer264
previously requested changes
Oct 31, 2025
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Just one thing that needs to change (the camelCase one), others are optional
cleptric
reviewed
Nov 6, 2025
Comment on lines
+21
to
+22
| 1. `browser.name` | ||
| 2. `browser.version` |
Member
There was a problem hiding this comment.
Aren't these extracted in Relay?
coolguyzone
reviewed
Nov 6, 2025
coolguyzone
reviewed
Nov 6, 2025
coolguyzone
reviewed
Nov 6, 2025
|
|
||
| ### Disabling Metrics | ||
|
|
||
| If you want to disable metrics collection entirely, you can do so by disabling the `_experimental.enableMetrics` flag: |
Contributor
There was a problem hiding this comment.
I'm a little confused by this; since this is an experimental feature that you need to manually turn on with enableMetrics: true I would assume it's false' by default, so is explicitly setting it to false` necessary?
Member
Author
There was a problem hiding this comment.
I left this in here since we'll change this on monday to the top-level enableMetrics option
coolguyzone
reviewed
Nov 6, 2025
coolguyzone
reviewed
Nov 6, 2025
coolguyzone
reviewed
Nov 6, 2025
coolguyzone
approved these changes
Nov 6, 2025
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Left a couple of small comments, looks good!
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dhrumil-Sentry
approved these changes
Nov 7, 2025
Co-authored-by: Jan Peer Stöcklmair <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: Alex Krawiec <[email protected]>
chargome
force-pushed
the
cg-js-metrics
branch
from
98a2d04 to
aaf48bd
Compare
codyde
added a commit
that referenced
this pull request
Nov 9, 2025
…ntry/sentry-docs into docs/span-metrics-examples * 'docs/span-metrics-examples' of https://github.com/getsentry/sentry-docs: (27 commits) Adding logs callout in relevant breadcrumbs docs. (#15432) docs(self-hosted): Troubleshooting guide to invalidate projectconfigs (#15377) docs(js): Add metrics page (#15353) fix encoding for minification (#15429) update instructions for string minification (#15421) getsentry/relay@938582a fix: typos in TanStack Start docs (#15425) feat: Add firebase docs integration (#15310) feat(develop-docs): add index and subpages for Telemetry Buffer (#15424) docs(integration): Update Linear Agent Docs (#15420) feat(cloudflare): Fixed snippet to be cloudflare specific (#15369) chore(aws-lambda): Add troubleshooting section with known issue (#15414) getsentry/relay@5e23f1a docs(size-analysis): Align code boxes and remove vcsInfo links (#15418) feat(develop-docs): Add telemetry buffer page (#15411) Add Composer requirement to PHP platform guide (#15319) Updated link for version compatability (#15311) (WIP) Mtopo27/size analysis docs (#15256) Metrics Product Docs (#15375) ref(develop/spans): Replace `is_remote` with `is_segment` in Span Protocol (#15415) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.