fix(node-core): Neutralize higher-priority env vars in getSentryRelease tests

cursoragent · claude · cursoragent · commit 7bf78a0a3a09 · 2026-03-03T22:16:45.000Z
Tests now stub GITHUB_SHA to empty string to prevent CI environment
variables from interfering with Heroku env var tests. This ensures
tests pass reliably on GitHub Actions and other CI environments where
git provider env vars are pre-set.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/packages/node-core/test/sdk/getSentryRelease.test.ts b/packages/node-core/test/sdk/getSentryRelease.test.ts
@@ -7,18 +7,21 @@ afterEach(() => {
 
 describe('getSentryRelease', () => {
   it('uses HEROKU_BUILD_COMMIT env var', () => {
+    vi.stubEnv('GITHUB_SHA', '');
     vi.stubEnv('HEROKU_BUILD_COMMIT', 'heroku-build-commit-sha');
 
     expect(getSentryRelease()).toBe('heroku-build-commit-sha');
   });
 
   it('falls back to HEROKU_SLUG_COMMIT if HEROKU_BUILD_COMMIT is not set', () => {
+    vi.stubEnv('GITHUB_SHA', '');
     vi.stubEnv('HEROKU_SLUG_COMMIT', 'heroku-slug-commit-sha');
 
     expect(getSentryRelease()).toBe('heroku-slug-commit-sha');
   });
 
   it('prefers HEROKU_BUILD_COMMIT over HEROKU_SLUG_COMMIT', () => {
+    vi.stubEnv('GITHUB_SHA', '');
     vi.stubEnv('HEROKU_BUILD_COMMIT', 'heroku-build-commit-sha');
     vi.stubEnv('HEROKU_SLUG_COMMIT', 'heroku-slug-commit-sha');
 
