fix(sveltekit): improve error handling in source map cleaning

cursoragent · claude · cursoragent · commit 96a66011b4a4 · 2026-03-09T13:27:24.000Z
- Changed overly broad catch block to check for ENOENT errors specifically
- Added debug logging for unexpected errors during source map cleaning
- Added regression tests for error handling in source map cleaning logic

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/packages/sveltekit/src/vite/sourceMaps.ts b/packages/sveltekit/src/vite/sourceMaps.ts
@@ -221,8 +221,12 @@ export async function makeCustomSentryVitePlugins(
             '',
           );
           await fs.promises.writeFile(mapFile, cleanedMapContent);
-        } catch {
-          // Map file doesn't exist, nothing to clean
+        } catch (e) {
+          const isKnownError = e instanceof Error && e.message.includes('ENOENT: no such file or directory, open');
+          if (debug && !isKnownError) {
+            // eslint-disable-next-line no-console
+            console.error('[Source Maps Plugin] error while cleaning source map', mapFile, e);
+          }
         }
       }
 
diff --git a/packages/sveltekit/test/vite/sourceMaps.test.ts b/packages/sveltekit/test/vite/sourceMaps.test.ts
@@ -1,4 +1,5 @@
 import { sentryVitePlugin } from '@sentry/vite-plugin';
+import * as fs from 'fs';
 import type { Plugin } from 'vite';
 import * as vite from 'vite';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
@@ -37,6 +38,20 @@ vi.mock('sorcery', async () => {
   };
 });
 
+vi.mock('fs', async () => {
+  const actual = (await vi.importActual('fs')) as typeof fs;
+  return {
+    ...actual,
+    existsSync: vi.fn(actual.existsSync),
+    readdirSync: vi.fn(actual.readdirSync),
+    promises: {
+      ...actual.promises,
+      readFile: vi.fn(actual.promises.readFile),
+      writeFile: vi.fn(actual.promises.writeFile),
+    },
+  };
+});
+
 beforeEach(() => {
   vi.clearAllMocks();
 });
@@ -212,6 +227,57 @@ describe('makeCustomSentryVitePlugins()', () => {
     expect(consoleWarnSpy).toHaveBeenCalledWith(expect.stringContaining('Failed to upload source maps'));
     expect(consoleLogSpy).toHaveBeenCalled();
   });
+
+  it('handles missing map files gracefully during source map cleaning', async () => {
+    const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+
+    vi.mocked(fs.existsSync).mockReturnValueOnce(true);
+    vi.mocked(fs.readdirSync).mockReturnValueOnce([{ name: 'test.js', isDirectory: () => false } as any]);
+    vi.mocked(fs.promises.readFile).mockRejectedValueOnce(
+      Object.assign(new Error('ENOENT: no such file or directory, open'), { code: 'ENOENT' }),
+    );
+
+    const plugin = await getSentryViteSubPlugin('sentry-sveltekit-debug-id-upload-plugin');
+
+    // @ts-expect-error this function exists!
+    plugin.configResolved({ build: { ssr: true } });
+    // @ts-expect-error this function exists!
+    await plugin.closeBundle();
+
+    expect(consoleErrorSpy).not.toHaveBeenCalled();
+  });
+
+  it('logs unexpected errors during source map cleaning when debug is enabled', async () => {
+    const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+
+    vi.mocked(fs.existsSync).mockReturnValueOnce(true);
+    vi.mocked(fs.readdirSync).mockReturnValueOnce([{ name: 'test.js', isDirectory: () => false } as any]);
+    vi.mocked(fs.promises.readFile).mockRejectedValueOnce(new Error('Permission denied'));
+
+    const plugins = await makeCustomSentryVitePlugins(
+      {
+        authToken: 'token',
+        org: 'org',
+        project: 'project',
+        adapter: 'other',
+        debug: true,
+      },
+      { kit: {} },
+    );
+
+    const plugin = plugins.find(p => p.name === 'sentry-sveltekit-debug-id-upload-plugin');
+
+    // @ts-expect-error this function exists!
+    plugin.configResolved({ build: { ssr: true } });
+    // @ts-expect-error this function exists!
+    await plugin.closeBundle();
+
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining('[Source Maps Plugin] error while cleaning source map'),
+      expect.any(String),
+      expect.any(Error),
+    );
+  });
 });
 
 describe('_getUpdatedSourceMapSettings', () => {

Original file line number	Diff line number	Diff line change
`@@ -221,8 +221,12 @@ export async function makeCustomSentryVitePlugins(`
`221`	`221`	`'',`
`222`	`222`	`);`
`223`	`223`	`await fs.promises.writeFile(mapFile, cleanedMapContent);`
`224`		`- } catch {`
`225`		`- // Map file doesn't exist, nothing to clean`
	`224`	`+ } catch (e) {`
	`225`	`+ const isKnownError = e instanceof Error && e.message.includes('ENOENT: no such file or directory, open');`
	`226`	`+ if (debug && !isKnownError) {`
	`227`	`+ // eslint-disable-next-line no-console`
	`228`	`+ console.error('[Source Maps Plugin] error while cleaning source map', mapFile, e);`
	`229`	`+ }`
`226`	`230`	`}`
`227`	`231`	`}`
`228`	`232`