Merged
Conversation
Contributor
size-limit report 📦
|
1 task
anonrig
force-pushed
the
update-biome-v1-5-0
branch
from
38b8eb9 to
fb1dbbc
Compare
|
I tested it with my local - fixed - version, and there are now 33 errors. All of them are formatting fixes :) |
anonrig
force-pushed
the
update-biome-v1-5-0
branch
from
fb1dbbc to
2ed2e97
Compare
anonrig
requested review from
a team,
Lms24 and
ale-cota
and removed request for
a team
Lms24
reviewed
Jan 16, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM, just had a question about the Json config.
anonrig
force-pushed
the
update-biome-v1-5-0
branch
from
2ed2e97 to
474548e
Compare
Lms24
approved these changes
Jan 16, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thx for explaining, let's update!
Also seriously hoping this update fixes the auto formatting bug when adding brackets in JSDoc comments.
Contributor
Author
I think that's Eslint not Biome? |
anonrig
force-pushed
the
update-biome-v1-5-0
branch
from
474548e to
9b1e358
Compare
Lms24
approved these changes
Dec 12, 2024
mydea
pushed a commit
that referenced
this pull request
Dec 12, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #10102 Co-authored-by: andreiborza <[email protected]>
Contributor
Author
|
🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.