Added skipSampleRate option to Raven.captureMessage and Raven.captureException#1079
Added skipSampleRate option to Raven.captureMessage and Raven.captureException#1079paksu wants to merge 1 commit intogetsentry:masterfrom
Conversation
|
Thanks @paksu! Could you also add this option to the docs? https://github.com/getsentry/raven-js/blob/master/docs/usage.rst |
|
@getsentry/javascript should we delete this attribute before sending a payload to the server or will it just be skipped during processing in there? |
|
Additional unhandled attributes show up as warnings/errors in the UI. |
|
Let's get rid of it before sending the payload then @paksu. My only concern with this solution, is that we're somewhat mixing |
9821b00 to
00db78b
Compare
|
Hey @kamilogorek. I added documentation, refactored into into options object and cleaned the options from request payload. Does it look good now? |
|
Looks good to me! What do you think about this solution @getsentry/javascript? It's a clear separation of data/options, which we can reuse in other js SDKs solutions. |
|
Question: should we also have I feel like we should explore how this could be done more elegantly. I'd almost prefer an option like |
Resolves Dependabot alert #1079 (CPU exhaustion in SvelteKit remote form deserialization, experimental only). Co-Authored-By: Claude Opus 4.6 <[email protected]>
… test (#19594) Resolves Dependabot alert #1079 (CPU exhaustion in SvelteKit remote form deserialization, experimental only). Co-authored-by: Claude Opus 4.6 <[email protected]>
Both of these methods now accept an option to skip global sampling rate. I added tests but documentation is missing because i'm not sure how I should document it and where.
This solves #1011