Skip to content

Added skipSampleRate option to Raven.captureMessage and Raven.captureException#1079

Closed
paksu wants to merge 1 commit intogetsentry:masterfrom
paksu:ignore-samplerate
Closed

Added skipSampleRate option to Raven.captureMessage and Raven.captureException#1079
paksu wants to merge 1 commit intogetsentry:masterfrom
paksu:ignore-samplerate

Conversation

@paksu
Copy link

@paksu paksu commented Oct 7, 2017

Both of these methods now accept an option to skip global sampling rate. I added tests but documentation is missing because i'm not sure how I should document it and where.

This solves #1011

@kamilogorek
Copy link
Contributor

Thanks @paksu! Could you also add this option to the docs? https://github.com/getsentry/raven-js/blob/master/docs/usage.rst

@kamilogorek
Copy link
Contributor

@getsentry/javascript should we delete this attribute before sending a payload to the server or will it just be skipped during processing in there?

@mitsuhiko
Copy link
Contributor

Additional unhandled attributes show up as warnings/errors in the UI.

@kamilogorek
Copy link
Contributor

kamilogorek commented Oct 9, 2017

Let's get rid of it before sending the payload then @paksu.

My only concern with this solution, is that we're somewhat mixing options with data and I'm not sure if we should do this. On the other hand adding additional options argument is even worse. I'm +1 for either leaving "as is", or wrapping all "functionality related options" to be passed as {options: {}} attribute.

@paksu paksu force-pushed the ignore-samplerate branch from 9821b00 to 00db78b Compare October 9, 2017 18:42
@paksu
Copy link
Author

paksu commented Oct 9, 2017

Hey @kamilogorek. I added documentation, refactored into into options object and cleaned the options from request payload. Does it look good now?

@kamilogorek
Copy link
Contributor

Looks good to me! What do you think about this solution @getsentry/javascript? It's a clear separation of data/options, which we can reuse in other js SDKs solutions.

@benvinegar
Copy link
Contributor

benvinegar commented Oct 12, 2017

Question: should we also have skipWhitelistsUrls and/or skipIgnoreErrors? (No.)

I feel like we should explore how this could be done more elegantly. I'd almost prefer an option like force: true bypass all checking altogether. At least that scales to be useful for more scenarios, both today and in the future.

chargome added a commit that referenced this pull request Mar 3, 2026
Resolves Dependabot alert #1079 (CPU exhaustion in SvelteKit remote
form deserialization, experimental only).

Co-Authored-By: Claude Opus 4.6 <[email protected]>
chargome added a commit that referenced this pull request Mar 3, 2026
… test (#19594)

Resolves Dependabot alert #1079 (CPU exhaustion in SvelteKit remote form
deserialization, experimental only).

Co-authored-by: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants