fix(nuxt): Re-export 'default' exports with rollup plugin#13984
Merged
s1gr1d merged 2 commits intosig/server-wrapping-defaultfrom Oct 15, 2024
Merged
fix(nuxt): Re-export 'default' exports with rollup plugin#13984s1gr1d merged 2 commits intosig/server-wrapping-defaultfrom
s1gr1d merged 2 commits intosig/server-wrapping-defaultfrom
Conversation
lforst
approved these changes
Oct 15, 2024
Contributor
size-limit report 📦
|
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
s1gr1d
added a commit
that referenced
this pull request
Oct 16, 2024
While the preset for Netlify exports the serverless handler function as
`export { D as default }`, the Vercel preset exports this handler as
`export { D as handler };`.
This PR makes some adaptions to the code generation in the plugin to
make it possible to re-export `default` functions. The previous snippet
did not work as `default` is obviously not allowed as a function name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the preset for Netlify exports the serverless handler function as
export { D as default }, the Vercel preset exports this handler asexport { D as handler };.This PR makes some adaptions to the code generation in the plugin to make it possible to re-export
defaultfunctions. The previous snippet did not work asdefaultis obviously not allowed as a function name.