fix(profiling): Make prune script compatible with node 22#14491
Merged
fix(profiling): Make prune script compatible with node 22#14491
Conversation
JonasBa
approved these changes
Nov 27, 2024
Member
|
Thank you @chargome |
AbhiPrasad
approved these changes
Nov 28, 2024
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Could we add a test to make sure this doesn't slip up in the future? We can do it in another PR.
Member
Author
|
@AbhiPrasad not sure what kind of test you would want to add? just a unit test for the script itself? |
Closed
3 tasks
JPeer264
added a commit
that referenced
this pull request
Dec 10, 2025
(closes #18428) (closes [JS-1266](https://linear.app/getsentry/issue/JS-1266/sentry-prune-profiler-binaries-does-not-recognize-nodejs-24-as-a-valid)) This adds support for Node v24 in the prune script. On top this also adds a test that is testing against the current Node version (as suggested in #14491 (review)). Since we have [a matrix](https://github.com/getsentry/sentry-javascript/blob/a906759fd8769d264498598dc16dab8af26377ea/.github/workflows/build.yml#L747) for our integration tests, this test would fail once we add Node v26 - where we are forced to update the ABI manually. Theoretically we could also use [node-abi](https://www.npmjs.com/package/node-abi), but decided against it to keep the dependencies low.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr just adds the ABI mapping for node 22 in the prune script.
(hopefully) closes #14488