fix(core): Filter out unactionable CEFSharp promise rejection error by default#14595
Merged
fix(core): Filter out unactionable CEFSharp promise rejection error by default#14595
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Dec 5, 2024
AbhiPrasad
approved these changes
Dec 5, 2024
Member
|
hmm, no strong feelings, but how important/common is this? Just thinking out loud, if it only happens infrequently, we could also just add it to the default inbound filters in relay? 🤔 it just adds some small bundle size, I am not against it but we should weigh this properly! |
Member
Author
|
Yeah I don't like the bundle size increase either. However, after some more googling, it looks like this happens quite frequently. Given that if we don't filter this out client-side, we still add the error to replays, I think we rather should eat the bytes 😬 I updated the PR description with various issues and posts I found. |
Lms24
force-pushed
the
lms/fix-core-filter-cefsharp-error
branch
from
6669586 to
54b573c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have internal user reports about an uncaught promise rejection being thrown by a .NET library called CEFSharp. This lib can embed chromium in a .NET app, which I guess means, a web page can be displayed within a .NET app. Apparently there's some problem that spams this error to some of our users.
This error seems to happen quite frequently and it's not the first time we're hearing about it:
This was also already reported in the CEFSharp repo
IMHO we can just filter this error by default, so this PR adds the error to be ignored by our default
inboundFiltersIntegration(which I still think has a completely misleading name by the way 😅)