Skip to content

ref!: Don't polyfill optional chaining and nullish coalescing#14603

Merged
lforst merged 6 commits intov9from
lforst-rip-polyfills
Dec 13, 2024
Merged

ref!: Don't polyfill optional chaining and nullish coalescing#14603
lforst merged 6 commits intov9from
lforst-rip-polyfills

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Dec 6, 2024

Resolves #8795

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.19 KB - -
@sentry/browser - with treeshaking flags 21.87 KB - -
@sentry/browser (incl. Tracing) 35.68 KB - -
@sentry/browser (incl. Tracing, Replay) 72.6 KB +0.02% +9 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.02 KB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.01 KB +0.15% +116 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.39 KB -0.01% -1 B 🔽
@sentry/browser (incl. Feedback) 39.95 KB - -
@sentry/browser (incl. sendFeedback) 27.81 KB - -
@sentry/browser (incl. FeedbackAsync) 32.6 KB - -
@sentry/react 25.87 KB - -
@sentry/react (incl. Tracing) 38.5 KB - -
@sentry/vue 27.4 KB - -
@sentry/vue (incl. Tracing) 37.52 KB - -
@sentry/svelte 23.36 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 37.34 KB - -
CDN Bundle (incl. Tracing, Replay) 72.12 KB -0.12% -88 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.48 KB -0.1% -77 B 🔽
CDN Bundle - uncompressed 71.56 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.85 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.91 KB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 237.13 KB -0.01% -6 B 🔽
@sentry/nextjs (client) 38.77 KB -0.04% -15 B 🔽
@sentry/sveltekit (client) 36.18 KB - -
@sentry/node 163.22 KB +0.18% +297 B 🔺
@sentry/node - without tracing 99.98 KB +0.17% +172 B 🔺
@sentry/aws-serverless 127.51 KB +0.17% +212 B 🔺

View base workflow run

mydea and others added 2 commits December 6, 2024 10:27
@mydea
ci(v9): Ensure CI runs on v8 & v9 branches (#14604)
7846b24 
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.
@mydea
ref!: Don't polyfill optional chaining and nullish coalescing
b9498ca
@mydea mydea force-pushed the lforst-rip-polyfills branch from 0b90a9a to b9498ca Compare December 6, 2024 10:34
@lforst lforst requested review from AbhiPrasad, Lms24 and mydea December 11, 2024 13:35
@lforst
Copy link
Contributor Author

lforst commented Dec 11, 2024

this still feels so scary

@mydea
Copy link
Member

mydea commented Dec 12, 2024

Just to double check: all our versions, both browser and node, now support these two features? If so, we should also remove the eslint rule disallowing this, I guess.

Actually, thinking about this, maybe before we merge this we should first adjust version support on the v9 branch? Why are Node 14 tests not failing with this 😅

@lforst
Copy link
Contributor Author

lforst commented Dec 12, 2024 •
edited
Loading

Just to double check: all our versions, both browser and node, now support these two features?

yes

If so, we should also remove the eslint rule disallowing this, I guess.

That is already part of this PR.

Actually, thinking about this, maybe before we merge this we should first adjust version support on the v9 branch? Why are Node 14 tests not failing with this 😅

Node 14 supports nullish coalescing and optional chaining.

@mydea
Copy link
Member

mydea commented Dec 12, 2024

ok, perfect, then let's :shipit:

mydea
mydea reviewed Dec 12, 2024
View reviewed changes
.github/workflows/build.yml
branches:
- develop
- master
- v9
Copy link
Member

@mydea mydea Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm why is this showing up here like this, are these changes not already on the v9 branch? is this just a GH UI problem?

Copy link
Contributor Author

@lforst lforst Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah super weird, idk 🤔 the changes are definitely on v9

@lforst lforst requested a review from mydea December 13, 2024 08:57
@lforst lforst merged commit 1c9544b into v9 Dec 13, 2024
@lforst lforst deleted the lforst-rip-polyfills branch December 13, 2024 10:02
mydea pushed a commit that referenced this pull request Dec 13, 2024
@mydea
ref!: Don't polyfill optional chaining and nullish coalescing (#14603)
7bf602c
mydea pushed a commit that referenced this pull request Dec 13, 2024
@mydea
ref!: Don't polyfill optional chaining and nullish coalescing (#14603)
f792e64
lforst pushed a commit that referenced this pull request Dec 13, 2024
@lforst
ref!: Don't polyfill optional chaining and nullish coalescing (#14603)
2ba42d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lforst @mydea