feat(nitro-utils): Add patchEventHandler helper for nitro#14614
Merged
andreiborza merged 2 commits intodevelopfrom Dec 6, 2024
Merged
feat(nitro-utils): Add patchEventHandler helper for nitro#14614andreiborza merged 2 commits intodevelopfrom
patchEventHandler helper for nitro#14614andreiborza merged 2 commits intodevelopfrom
Conversation
s1gr1d
approved these changes
Dec 6, 2024
| * A helper to patch a given `h3` event handler, ensuring that | ||
| * requests are properly isolated and data is flushed to Sentry. | ||
| */ | ||
| export function patchEventHandler(handler: EventHandler): EventHandler { |
Member
There was a problem hiding this comment.
L: We could give this a name that speaks more for itself (with the downside that it gets long). E.g. forkScopeAndFlushServerless
Member
Author
There was a problem hiding this comment.
I opted for a shorter name because where it's imported from gives enough context. But happy to change if you think otherwise, let me know :)
Member
Author
There was a problem hiding this comment.
Will keep it then, can always change later since this isn't really public api.
Co-authored-by: Sigrid Huemer <[email protected]>
andreiborza
added a commit
that referenced
this pull request
Dec 6, 2024
E2E tests and usage in nuxt in: #14612 --------- Co-authored-by: Sigrid Huemer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E tests and usage in nuxt in: #14612