Conversation
3 tasks
s1gr1d
approved these changes
Jan 9, 2025
Member
s1gr1d
left a comment
s1gr1d
left a comment
There was a problem hiding this comment.
Thanks for debugging and solving this 🙌
Lms24
added a commit
that referenced
this pull request
Jan 9, 2025
…ps upload (#14942) - replace the original release management plugin with a custom one where we start release creation on `closeBundle` - replace the original file deletion plugin with a custom one where we start deletion on `closeBundle` - in both cases, further ensuresthat the plugin is only invoked for build and as late as possible (`enforce: 'post'`). - searche for the release management plugin by its old and new name introduced in getsentry/sentry-javascript-bundler-plugins#647 - slightly rename the custom source maps uploading plugin for better convention; as well as some variables for better readability - add unit tests for the new custom sub plugins
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a source maps deletion bug in the Sentry SvelteKit SDK reported in #14131.
After debugging this extensively, the root cause turned out to be a timing issue. For SvelteKit, we have to move all invocations of the
writeBundlehook in the sub-plugins of the original Sentry Vite plugin to thecloseBundlehook, to ensure that the second build made when the SvelteKit adapter is invoked is also awaited correctly. We did this correctly for the debug id source maps upload plugin but did not do it for the release management and file deletion plugins.The changed order of things caused a deadlock situations due to our deletion plugin waiting on upload and release plugins to finish. Since the deletion plugin was started earlier than the upload plugin, it was awaiting something that wasn't even started yet.
This PR now:
closeBundlecloseBundleenforce: 'post'). All of these three things ensure now that the deadlock situation is resolved.closes #14131
fixes #12660