ref(core): Ensure non-sampled spans are NonRecordingSpans#14955
Closed
ref(core): Ensure non-sampled spans are NonRecordingSpans#14955
Conversation
Contributor
size-limit report 📦
|
s1gr1d
approved these changes
Jan 9, 2025
81cedd8 to
a011992
Compare
❌ 8 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This was referenced Jan 9, 2025
mydea
added a commit
that referenced
this pull request
Jan 10, 2025
Otherwise, parts of the DSC will be missing - we try to make it as complete as we can. Since the span cannot be updated anyhow (e.g. the name cannot be changed), we can safely freeze this at this time. Extracted out of #14955
mydea
added a commit
that referenced
this pull request
Jan 10, 2025
…tion` (#14959) Extracted this out of #14955 We used to rely on implied stuff here quite a bit, which breaks if we start returning non recording spans. Honestly this just surfaces that this is not really ideal as it is 😬 We already pass the client around there everywhere, so this PR updates this so we keep the active idle span as non-enumerable prop on the client, ensuring this is consistent and "pure".
ce4c3ca to
984a0de
Compare
ecc9230 to
6bac717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that we were still using a regular SentrySpan for unsampled spans, instead of NonRecordingSpans. This should be more "consistent" now.