Skip to content

fix(v8/sveltekit): Ensure source maps deletion is called after source maps upload#14963

Merged
Lms24 merged 1 commit intov8from
lms/fix-sveltekit-sourcemap-deletion-v8-backport
Jan 9, 2025
Merged

fix(v8/sveltekit): Ensure source maps deletion is called after source maps upload#14963
Lms24 merged 1 commit intov8from
lms/fix-sveltekit-sourcemap-deletion-v8-backport

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 9, 2025

Backport of #14942

…ps upload (#14942)

- replace the original release management plugin with a custom one
where we start release creation on `closeBundle`
- replace the original file deletion plugin with a custom one where we
start deletion on `closeBundle`
- in both cases, further ensuresthat the plugin is only invoked for
build and as late as possible (`enforce: 'post'`). 
- searche for the release management plugin by its old and new name
introduced in
getsentry/sentry-javascript-bundler-plugins#647
- slightly rename the custom source maps uploading plugin for better
convention; as well as some variables for better readability
- add unit tests for the new custom sub plugins
@Lms24 Lms24 changed the title fix(sveltekit): Ensure source maps deletion is called after source ma… fix(v8/sveltekit): Ensure source maps deletion is called after source ma… Jan 9, 2025
@Lms24 Lms24 requested a review from s1gr1d January 9, 2025 15:07
@Lms24 Lms24 self-assigned this Jan 9, 2025
@Lms24 Lms24 merged commit af00c8f into v8 Jan 9, 2025
@Lms24 Lms24 deleted the lms/fix-sveltekit-sourcemap-deletion-v8-backport branch January 9, 2025 16:26
@Lms24 Lms24 changed the title fix(v8/sveltekit): Ensure source maps deletion is called after source ma… fix(v8/sveltekit): Ensure source maps deletion is called after source maps upload Jan 9, 2025
@Lms24
Copy link
Member Author

Lms24 commented Jan 9, 2025

Argh I missed the commit message changing itself. Sorry to whoever is making the changelog 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants