Merged
Conversation
added 2 commits
January 20, 2025 14:50
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mydea
reviewed
Jan 20, 2025
packages/aws-serverless/src/sdk.ts
Outdated
| // Otherwise, we create two root spans (one from otel, one from our wrapper). | ||
| // If Otel instrumentation didn't work or was filtered by users, we still want to trace the handler. | ||
| // TODO(v9): Since bumping the OTEL Instrumentation, this is likely not needed anymore, we can possibly remove this | ||
| // TODO(v9): Since bumping the OTEL Instrumentation, this is likely not needed anymore, we can possibly remove this (can be done whenever since it would be non-breaking) |
Member
There was a problem hiding this comment.
should we just remove the (v9) suffix here, possibly? 🤔
Contributor
Author
There was a problem hiding this comment.
yeah I guess - I originally wanted to keep it because it's a somewhat valuable priority gauge when grepping for TODO(
mydea
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #14299
Updates comments to clarify what needs to be done in v9 and what doesn't.