feat!: Only collect ip addresses with sendDefaultPii: true#15084
Merged
feat!: Only collect ip addresses with sendDefaultPii: true#15084
sendDefaultPii: true#15084Conversation
timfish
approved these changes
Jan 20, 2025
Contributor
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mydea
reviewed
Jan 20, 2025
packages/browser/src/client.ts
Outdated
|
|
||
| this.on('postprocessEvent', event => { | ||
| addAutoIpAddressToUser(event); | ||
| if (this._options.sendDefaultPii) { |
Member
There was a problem hiding this comment.
hmm, I wonder if we can just conditionally not add both of these hooks at all here if this is not on? 🤔 a bit simpler, you loose the ability to flip this option later, but is this something we want to/need to support?
Contributor
Author
There was a problem hiding this comment.
uh totally. Mutating options is kinda not something we intentionally support. Whenever it works it is usually by accident.
mydea
reviewed
Jan 20, 2025
|
|
||
| if (normalizedRequest) { | ||
| addNormalizedRequestDataToEvent(event, normalizedRequest, { ipAddress }, include); | ||
| addNormalizedRequestDataToEvent(event, normalizedRequest, { ipAddress }, include, client); |
Member
There was a problem hiding this comment.
l: This is also fine, but what if we mutated include here instead? IMHO the addNormalizedRequestDataToEvent does not need to know of the client etc, we could do:
addNormalizedRequestDataToEvent(event, normalizedRequest, { ipAddress }, { ip: client.getOptions().sendDefaultPii, ...include });or something like this? (not quite, as ip is set by default, but logic wise something like this...)
But I'm also OK with leaving it as it is here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #5347 (comment)