chore(repo): Removing unused files#15140
Merged
Lms24 merged 1 commit intogetsentry:developfrom Jan 23, 2025
Merged
Conversation
davidturissini
commented
Jan 23, 2025
| @@ -1,8 +0,0 @@ | |||
| import type { BaseTransportOptions } from '@sentry/core'; | |||
|
|
|||
| export interface VercelEdgeTransportOptions extends BaseTransportOptions { | |||
Contributor
Author
There was a problem hiding this comment.
This is defined and referenced from https://github.com/getsentry/sentry-javascript/blob/develop/packages/vercel-edge/src/transports/types.ts#L3 instead of this file. Probably was refactored at some point and missed during cleanup
davidturissini
commented
Jan 23, 2025
| @@ -1 +0,0 @@ | |||
| export * from './createSession'; | |||
Contributor
Author
There was a problem hiding this comment.
createSession is just imported directly so this just removes in barrel/index file
Lms24
changed the title
Lms24
changed the title
Lms24
approved these changes
Jan 23, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for contributing @davidturissini!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think remove-unused found more unused files, this time in
replay-internalandvercel-edge.lintandtestcommands run fine. All build tasks seem to be working although I cannot get@sentry/profiling-nodeto ever build locally due to some fungypstuffBefore submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).