test: Only run flaky test detection for chromium#15264
Merged
Conversation
This streamlines this a bit and should be good enough here.
s1gr1d
approved these changes
Feb 3, 2025
Lms24
reviewed
Feb 3, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Not gonna block this but afaik this job isn't blocking a merge and running the flake detector for other browser potentially catches more flakes 🤔 No strong opinions, feel free to merge anyway but maybe something to consider
Member
Author
It just takes way longer and I've never seen this catch a bug so far 🤔 we can always add it back if we ever find a flake that only happens on webkit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This streamlines this a bit and should be good enough here.