feat(core): Rename hasTracingEnabled to hasSpansEnabled#15309
Merged
Conversation
mydea
approved these changes
Feb 5, 2025
Contributor
size-limit report 📦
|
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Member
Author
|
Side-note: I went through every usage call we make to this function while renaming and 1. the conditions now read way more clearer and 2. I didn't come acrross suspicios usages where this check doesn't seem applicable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
hasTracingEnabledutility function tohasSpansEnabled. The original name is causing confusion and doesn't represent what the function actually does: determining if the SDK is configured to record spans. This function does not check if trace propagation without span recording (or "Tracing without Performance") is enabled (which it basically always is).Since this function is exported from
@sentry/core,hasTracingEnabledwas deprecated and will be removed in v10.