ref(browser): Skip browser extension warning in non-debug builds#15310
Merged
ref(browser): Skip browser extension warning in non-debug builds#15310
Conversation
Contributor
size-limit report 📦
|
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
reviewed
Feb 5, 2025
packages/browser/src/sdk.ts
Outdated
| const options = applyDefaultOptions(browserOptions); | ||
|
|
||
| if (!options.skipBrowserExtensionCheck && shouldShowBrowserExtensionError()) { | ||
| if (DEBUG_BUILD && !options.skipBrowserExtensionCheck && shouldShowBrowserExtensionError()) { |
Member
There was a problem hiding this comment.
A side-effect to keep in mind is that our regular CDN bundles would then still init the SDK in browser extensions. If it was just about the warning, I'd say that's fine but we bail in the same block. Should we just guard the console log part instead?
Member
Author
There was a problem hiding this comment.
ah, yeah, you are right of course 🤔 i mean, this will have less savings (as the code to check all of this still runs) but is probably safer 👍
mydea
force-pushed
the
fn/guard-browser-extension-check
branch
from
cae14ab to
514ca96
Compare
I think it is fair to exclude this here, saving a few bytes...?
mydea
force-pushed
the
fn/guard-browser-extension-check
branch
from
514ca96 to
5d249bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is fair to exclude this here, saving a few bytes...?