Skip to content

feat(pinia)!: Include state of all stores in breadcrumb#15312

Merged
s1gr1d merged 2 commits intodevelopfrom
sig/pinia-support-multiple-stores
Feb 5, 2025
Merged

feat(pinia)!: Include state of all stores in breadcrumb#15312
s1gr1d merged 2 commits intodevelopfrom
sig/pinia-support-multiple-stores

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 5, 2025

Adds all stores to the state object.
closes #15232

Before, it could only hold the state of the currently changed store like:

// before
{
    count: 0,
    name: 'Counter Store'
}

Now, when having a counter and a cart store, it looks like this (using the store IDs as the object keys):

// now
{
    cart: {
      rawItems: ['item'],
    },
    counter: {
      count: 0,
      name: 'Counter Store',
    },
  }

@s1gr1d s1gr1d requested review from Lms24 and onurtemizkan February 5, 2025 15:01
@codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
253 1 252 8
View the full list of 1 ❄️ flaky tests 
sdk.test.ts SDK-internal behavior › Injects fetch proxy script for SvelteKit<2.16.0

Flake rate in main: 30.00% (Passed 14 times, Failed 6 times)

Stack Traces | 0.143s run time 
sdk.test.ts:4:3 Injects fetch proxy script for SvelteKit<2.16.0

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Lms24
Lms24 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@s1gr1d s1gr1d mentioned this pull request Feb 5, 2025
Closed
3 tasks
@s1gr1d s1gr1d merged commit 4b6dff7 into develop Feb 5, 2025
120 of 122 checks passed
@s1gr1d s1gr1d deleted the sig/pinia-support-multiple-stores branch February 5, 2025 15:47
@illialiven
Copy link

illialiven commented Mar 4, 2025 •
edited
Loading

Hello, @s1gr1d!
Seems that this code causes multiple attachments for each store to be sent for event. Meaning that for n stores we'll get n attachments with same contents. It happens cause plugin is used by each store. Can it somehow be changed without changing the logic of plugin setup?

@s1gr1d s1gr1d mentioned this pull request Mar 5, 2025
Closed
@s1gr1d
Copy link
Member Author

s1gr1d commented Mar 5, 2025

Hy @illialiven,
thanks for noticing!
I created an issue for this: #15587

In general, please consider creating issues because comments on closed PRs/issues tend to be overlooked sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onurtemizkan onurtemizkan onurtemizkan approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only latest Pinia store included in state.

4 participants

@s1gr1d @illialiven @onurtemizkan @Lms24