Merged
Conversation
AbhiPrasad
requested review from
chargome and
s1gr1d
and removed request for
a team
Contributor
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
s1gr1d
reviewed
Feb 24, 2025
| "@opentelemetry/instrumentation-nestjs-core": "0.44.0", | ||
| "@opentelemetry/semantic-conventions": "^1.27.0", | ||
| "@opentelemetry/instrumentation": "0.57.2", | ||
| "@opentelemetry/instrumentation-nestjs-core": "0.44.1", |
Member
There was a problem hiding this comment.
We are actually not using this package in the Nest.js package. I think it's just there so we don't forget about upgrading it until this PR is merged.
For the time being, we have inlined the instrumentation in this PR.
Basically, we only changed this line: const supportedVersions = ['>=4.0.0 <12'];
But I'm not sure if it's worth it to update the inlined instrumentation.
Contributor
Author
There was a problem hiding this comment.
Let's keep it upgraded so that all the underlying deps have the same versions.
s1gr1d
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main thing this change does is to upgrade all the packages to use https://github.com/open-telemetry/opentelemetry-js/releases/tag/experimental%2Fv0.57.1
Other changes include:
We can think about adding Knex as a default instrumentation.