Merged
Conversation
AbhiPrasad
requested review from
chargome and
stephanie-anderson
and removed request for
a team
AbhiPrasad
force-pushed
the
abhi-vitest-gatsby
branch
from
f2b22b3 to
f0ed82d
Compare
timfish
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #11084
Before:
6.437 sAfter:
1.23sThe first thing we did was migrate the
pretest.tsscript to use a vitest global setup instead. This is cleaner, and should ensure it never gets lost in refactors either.After that we did the conversion. The trickiest thing to change was
packages/gatsby/test/gatsby-node.test.ts, asgatsby-node.jsis a CJS file. This is tricky to patch properly with vitest for the spy. To get around this, we monkeypatchModule._loadtemporarily to load a stub which we defined invi.hoisted(which hoists it to the top so it's always available).