fix(react-router): Fix config type import#15583
Merged
chargome merged 2 commits intogetsentry:developfrom Mar 6, 2025
Merged
Conversation
lforst
approved these changes
Mar 5, 2025
Contributor
|
Thanks! |
Contributor
|
@chargome what's going on here? You remember why we have the dist here? Seems to fail TS without. |
Member
|
Damn yeah the config entrypoint breaks our ts build, which is why I used dist – din't realize until now that this types the hook |
Contributor
|
Yeah we can vendor it, but I would also advocate for contributing upstream to fix the typings |
Member
|
Their typings look alright, maybe this is something on our end |
Contributor
Author
|
Ah yeah, sorry for not building this prior to opening the PR. Here's the TypeScript error: Currently, |
chargome
added a commit
that referenced
this pull request
Mar 6, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15583 Co-authored-by: chargome <[email protected]>
namoscato
added a commit
to namoscato/tiny-truths
that referenced
this pull request
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@react-router/dev/dist/*is not a valid entry point. This results insentryOnBuildEndbeing typed asanyas illustrated in this CI run.The workaround is a type assertion in the interim, i.e. namoscato/tiny-truths@9c33bf1
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
If you've added code that should be tested, please add tests.yarn lint) & (yarn test).