Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Collaborator
Author
|
This is blocked by: |
…sentry-javascript into timfish/feat/pino-integration
Collaborator
Author
|
I think these both need to be merged and released before we can use the hooks in production: |
…sentry-javascript into timfish/feat/pino-integration
…sentry-javascript into timfish/feat/pino-integration
AbhiPrasad
reviewed
Sep 24, 2025
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Really happy with this. Once we lock down the options surface, we should be good to merge!
Collaborator
Author
|
Just realised we probably also want an integration test for the latest Pino that includes the tracing channel! |
194f02e to
ac49a64
Compare
AbhiPrasad
approved these changes
Oct 2, 2025
6 tasks
AbhiPrasad
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 8, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Documents change in getsentry/sentry-javascript#17584 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
- Adds `@apm-js-collab/tracing-hooks` as a dependency - Integrations can register instrumentations which causes the `@apm-js-collab/tracing-hooks` ESM hook and require patching to be initialised later - The `@apm-js-collab/*` dependencies only get included in a bundle when they are used by an integration - Adds a `pinoIntegration` that: - Is not enabled by default (see below) - Registers where it needs code injecting into the pino library - Hooks the tracing channel events, including the channel added to `[email protected]` - Captures Sentry logs for pino logs - Captures in the correct tracing context because this is all sync! - Captures exception/message events for the configured `eventLevels` ## Supported Node versions We can't enable this integration by default because `TracingChannel`, injected by `@apm-js-collab/code-transformer` requires Node >= v19.9.0 or v18.19.0.
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
This package was added in getsentry#16652, but with the merge of getsentry#17584 we can remove it. We will recommend users use the `pinoIntegration` because it's way easier to set up and tracing works ootb. This package was never published (no craft config) so it's safe to remove.
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pinofor Sentry Structured Logs #15952This PR:
@apm-js-collab/tracing-hooksas a dependency@apm-js-collab/tracing-hooksESM hook and require patching to be initialised later@apm-js-collab/*dependencies only get included in a bundle when they are used by an integrationpinoIntegrationthat:[email protected]eventLevelsSupported Node versions
We can't enable this integration by default because
TracingChannel, injected by@apm-js-collab/code-transformerrequires Node >= v19.9.0 or v18.19.0.