fix(core): Improve uuid performance#17938
Merged
AbhiPrasad merged 11 commits intodevelopfrom Oct 21, 2025
Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
timfish
force-pushed
the
timfish/fix/improve-uuid-perf
branch
from
00f3d58 to
42ece80
Compare
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AbhiPrasad
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some benchmarking:
uuid4function #15862 (comment)I found that in Node.js at least, getting a single byte via
crypto.getRandomValues()is 10x slower than theMath.random()version so we should dropgetRandomValuesusage entirely.I also found that for the
Math.random()fallback code, we generated the base starting string (10000000100040008000100000000000) on every call touuid4(). If we cache this value we get a ~20% improvement in this path.In the browser
crypto.randomUUID()is only available in secure contexts so our fallback code should have good performance too!