chore(browser): upgrade fake-indexeddb to v6#17975
Merged
AbhiPrasad merged 1 commit intodevelopfrom Oct 28, 2025
Merged
Conversation
AbhiPrasad
requested review from
Lms24 and
andreiborza
and removed request for
a team
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
AbhiPrasad
force-pushed
the
abhi-upgrade-fake-indexeddb-v6
branch
2 times, most recently
from
683e5f3 to
b4a6ade
Compare
AbhiPrasad
force-pushed
the
abhi-upgrade-fake-indexeddb-v6
branch
from
b4a6ade to
756aba5
Compare
andreiborza
approved these changes
Oct 28, 2025
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
LGTM, but I haven't checked changes between v4 and v6. Is there anything in there that could break us?
Contributor
Author
|
Nothing from what I saw, but we can revert if we see something suspicious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: https://github.com/dumbmatter/fakeIndexedDB/blob/master/CHANGELOG.md
removes a structured clone polyfill, which is fine because we are node 18+ in the SDK. This helps reduce dep count in
yarn.lock.