ref(browser): Remove truncation when not needed#18051
Merged
Conversation
andreiborza
approved these changes
Oct 29, 2025
Contributor
size-limit report 📦
|
Lms24
approved these changes
Oct 29, 2025
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| // Trim URL to the first 200 characters. | ||
| entry.url && (attributes['lcp.url'] = entry.url.trim().slice(0, 200)); | ||
| entry.url && (attributes['lcp.url'] = entry.url); |
There was a problem hiding this comment.
Bug: Data URL Truncation Risk in URL Handling
Removing the truncation of entry.url without handling data URLs could cause issues when the LCP element uses a data URL (e.g., data:image/png;base64,<very long base64 string>). Unlike globalhandlers.ts which has special handling for data URLs (lines 210-215), this code directly assigns the URL without any length protection. Data URLs with embedded base64 images can be extremely long (potentially megabytes), which could cause problems with attribute storage, transmission, or display in the Sentry UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining places where we truncate, although not needed.
part of #17389