Fix spotlight config test assertion#18196
Merged
BYK merged 1 commit intofeat/node-spotlight-precedence-fixfrom Nov 13, 2025
Merged
Fix spotlight config test assertion#18196BYK merged 1 commit intofeat/node-spotlight-precedence-fixfrom
BYK merged 1 commit intofeat/node-spotlight-precedence-fixfrom
Conversation
Co-authored-by: burak.kaya <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Fixes a test failure where
process.env.SENTRY_SPOTLIGHTwas not cleaned up after a test, causing environment variable pollution for subsequent tests.The failing test expected
spotlight: trueto resolve totrue, but due to the lingering environment variable, it received the URL fromSENTRY_SPOTLIGHTinstead.This PR adds an
afterEachhook to thespotlight configurationdescribe block to ensureprocess.env.SENTRY_SPOTLIGHTis deleted after each test, preventing cross-test contamination.