fix(core): Check fetch support with data URL#18225
Merged
Conversation
3 tasks
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Deno Referrer Policy URL Fix
The supportsReferrerPolicy function still uses new Request('_', ...) with an invalid URL, which will fail in Deno for the same reason the PR fixed in _isFetchSupported. Deno requires valid URLs for the Request constructor, so '_' needs to be changed to a valid URL like 'data:,' to maintain consistency with the fix.
packages/core/src/utils/supports.ts#L171-L172
sentry-javascript/packages/core/src/utils/supports.ts
Lines 171 to 172 in 432d9d7
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
JPeer264
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Deno requires a valid URL when calling
new Request,example.comwas used but this caused problems.This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno.
Fixes: #18218
Previous PR for that: #5630