feat(node): Add ignoreConnectSpans option to postgresIntegration#19291
Merged
feat(node): Add ignoreConnectSpans option to postgresIntegration#19291
ignoreConnectSpans option to postgresIntegration#19291Conversation
![sentry[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
dev-packages/node-integration-tests/suites/tracing/postgres/test.ts
Outdated
Show resolved
Hide resolved
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
dev-packages/node-integration-tests/suites/tracing/postgres/test.ts
Outdated
Show resolved
Hide resolved
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
requested review from
a team,
RulaKhaled,
andreiborza and
mydea
and removed request for
a team and
mydea
This was referenced Feb 11, 2026
Lms24
force-pushed
the
lms/feat-node-pg-ignoreConnect
branch
from
56a235d to
0a4d42c
Compare
Lms24
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Mar 4, 2026
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Adds documentation for getsentry/sentry-javascript#19291 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTel's
PgInstrumentationexposes an option to ignorepg(.pool).connectspans.This option was added recently in open-telemetry/opentelemetry-js-contrib#3280. We should allow users to configure our wrapping
postgresIntegrationwith the same option.Usage:
Side product of looking into #19290 which turned out not to be an SDK issue . But this reminded me that we had #16536 open which we should tackle at some point. So I figured, why not now.
Docs PR: getsentry/sentry-docs#16358
closes #16536