fix(node): Prevent duplicate LangChain spans from double module patching#19684
Merged
nicohrubec merged 1 commit intodevelopfrom Mar 6, 2026
Merged
fix(node): Prevent duplicate LangChain spans from double module patching#19684nicohrubec merged 1 commit intodevelopfrom
nicohrubec merged 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
linear-code
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LangChain instrumentation registers both a module-level and a file-level hook for each provider package (e.g.
@langchain/openai). Both hooks call _patch, which wraps the same prototype methods (invoke, stream, batch) with a newproxy and callback handler. This results in every LangChain call producing duplicate gen_ai.chat spans. The fix adds a
__sentry_patched__guard on the prototype to skip patching if it's already been done.Closes #19685 (added automatically)