fix(vue): Don't call next in Vue router 4 instrumentation#8351
Merged
Conversation
3 tasks
Lms24
requested review from
a team,
mydea and
stephanie-anderson
and removed request for
a team
mydea
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue Router 4 no longer exposes a
nextresolver function to call inside abeforeEachrouter guard callback. Instead it will resolve the hook when the callback function returns.This PR checks if
nextis available and only calls it then. Also it adjusts the types accordingly and adds a test that previously failed.fixes #8349