fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Conversation
Contributor
size-limit report 📦
|
2 tasks
mydea
approved these changes
Jul 20, 2023
lforst
pushed a commit
that referenced
this pull request
Mar 31, 2025
Ref https://github.com/getsentry/projects/issues/837 for for not truncating error messages and letting relay do that. Kinda undoes #8593 Should be merged after #15819 because otherwise, we keep humongous strings in memory.
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 3, 2025
Ref https://github.com/getsentry/projects/issues/837 for for not truncating error messages and letting relay do that. Kinda undoes #8593 Should be merged after #15819 because otherwise, we keep humongous strings in memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #8580, aggregate exceptions'
exception.valuestrings weren't truncated correctly in our event preparation pipeline. The tricky part here is that theLinkedErrorsintegration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.closes #8580