feat(feedback): Bootstrap feedback integration#9139
Merged
Conversation
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
packages/feedback/jest.setup.ts
Outdated
| @@ -0,0 +1,272 @@ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-member-access */ | |||
Member
There was a problem hiding this comment.
this file we prob. don't need here as well
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
mydea
reviewed
Sep 29, 2023
c298lee
force-pushed
the
feat-feedback-bootstrap-feedback-integration
branch
from
11ebf5f to
2fc93b0
Compare
Contributor
size-limit report 📦
|
billyvg
force-pushed
the
feat-feedback-bootstrap-feedback-integration
branch
2 times, most recently
from
3063b07 to
f71e413
Compare
billyvg
approved these changes
Oct 13, 2023
AbhiPrasad
reviewed
Oct 13, 2023
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Are we aiming to publish this next release? If so we should update the craft.yml here as well.
| ## Installation | ||
|
|
||
| Feedback can be imported from `@sentry/browser`, or a respective SDK package like `@sentry/react` or `@sentry/vue`. | ||
| You don't need to install anything in order to use Feedback. The minimum version that includes Feedback is <<CHANGEME>>. |
Member
There was a problem hiding this comment.
Yeah still TODO until we add it to core
packages/feedback/package.json
Outdated
| "homepage": "https://docs.sentry.io/platforms/javascript/", | ||
| "devDependencies": { | ||
| "@babel/core": "^7.17.5", | ||
| "tslib": "^2.4.1 || ^1.9.3" |
Contributor
There was a problem hiding this comment.
Do we need the babel dev dep? I also think tslib needs to be a regular dependency.
Member
|
@AbhiPrasad This won't be published with main SDK pkgs for now, will just be published to the sentry-internal namespace. |
This reverts commit f71e413.
billyvg
force-pushed
the
feat-feedback-bootstrap-feedback-integration
branch
from
06d85ca to
4b3edc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate feedback into sdk