Merged
Conversation
timfish
commented
Jan 30, 2025
Comment on lines
-44
to
-46
| if (abi === '93') { | ||
| return require('./sentry_cpu_profiler-darwin-x64-93.node'); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This PR removes all references to the 93 abi binaries because we no longer build them and they were causing the new tests to fail!
Member
There was a problem hiding this comment.
should this be a separate PR, where we stop building those? This does not seem to be a test-only change here? Or is it just not used anymore anywhere?
Collaborator
Author
There was a problem hiding this comment.
should this be a separate PR, where we stop building those?
We haven't been building these binaries for a while. I think they are from Node 16. The new tests simply highlighted that these requires don't point to anything and needed cleaning up.
mydea
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.