[Autolink] Store positioning info for url_match#201
Merged
phillmv merged 1 commit intogithub:masterfrom Jan 31, 2023
bdotdub:patch-1
Merged
[Autolink] Store positioning info for url_match#201phillmv merged 1 commit intogithub:masterfrom bdotdub:patch-1
phillmv merged 1 commit intogithub:masterfrom
bdotdub:patch-1
Conversation
Currently for the autolink extensioon, only `www_match` correctly returns correct positioning when calling `cmark_node_get_start_line`/`cmark_node_get_start_column`/`cmark_node_get_end_line`/`cmark_node_get_end_column`. This PR adds positioning support for the `url_match` function.
Author
|
I couldn't figure out how to test this in this repo, but you can see it tested here: bdotdub/cmark-gfm-swift@d543098 |
kevinbackhouse
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently for the autolink extension, only
www_matchcorrectly returns correct positioning when callingcmark_node_get_start_line/cmark_node_get_start_column/cmark_node_get_end_line/cmark_node_get_end_column. This is done here: https://github.com/github/cmark-gfm/blob/master/extensions/autolink.c#L191-L193This PR adds positioning support for the
url_matchfunction.