Add HTML attributes#233
Closed
talum wants to merge 1481 commits intofix-footnotes-plus-fix-fnref-label-and-backrefsfrom
Closed
Add HTML attributes#233talum wants to merge 1481 commits intofix-footnotes-plus-fix-fnref-label-and-backrefsfrom
talum wants to merge 1481 commits intofix-footnotes-plus-fix-fnref-label-and-backrefsfrom
Conversation
blocks: Fix quadratic behavior in `finalize`
For some reason this wasn't getting set in processing libcmark.pc.in, and we were getting the wrong entry in libcmark.pc. (See #236) The new approach sets an internal libdir variable to lib${LIB_SUFFIX}. This variable is used both to set the install destination and in the libcmark.pc.in template. Closes #236. However, I'd welcome comments from @juhp who originally added CMAKE_INSTALL_LIBDIR in #185. I think that the new system should work fine with Fedora, since LIB_SUFFIX will be set appropriately, but some testing is in order.
Due to a mistake, 0.28.1 installed libcmark.a into include/. Closes #238.
Fixes installation error under some CMake versions, notably kalakris' CMake backport often used with Travis.
Include GNUInstallDirs in src/CMakeLists.txt
Add sourcepos info for inlines
> 32 nested balanced parens in a link is bananas
Add more pathological tests.
Tests must complete in 8 seconds or are errors.
This allows us to include tests that we don't yet know how to pass.
* Shift includes around for proper header install * msvc fixes
Fixes issue #247.
Generate export header for static-only build
* Add baseline test * Some preliminary work. * cont'd * Add footnote reference * Start postprocessing * MVP: tests pass * commonmark footnote out * Factor out reference/footnote maps * fix a memory leak & some asserts * We don't assert/check snprintf elsewhere * Remove bad linear search, extend test case * cleanup * man page update * add footnotes as option * bugfix (found in comrak first!) * Shift static var into renderer struct
… intent more obvious.
…ade sure to free allocated string in commonmark.c
tldr, avoid freeing memory before passing it along to another function.
Sometimes, when cleaning up unusued footnotes, two footnote->nodes may end up referencing each other. As they get free()'d up, this can lead to problems. Instead, first we unlink every node and _then_ free them up.
813ab1e to
16a9624
Compare
…notes-plus-fix-fnref-label-and-backrefs
Add `aria-label` for accessibility. Add `data-footnotes` as an identifier.
…en class is sanitized
This will describe the footnotes section and improve accessibility. It can be hidden visually.
This reverts commit e4a09ed. We decided to move this into our own pipeline instead.
5e29ade to
3b62e1b
Compare
3b62e1b to
7a4f044
Compare
Author
|
I definitely mangled this commit history, so I'm going to close it and retry. |
Author
|
Decided to remove the h2 and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support rendering footnotes in markdown on GitHub.com, we'd like to add a few changes to make the markup easier to style.
This PR adds
aria-labelfor accessibilityaria-describedby="footnote-label"for accessibilitydata-footnotesas another identifier for the<section>data-footnote-refdata-footnote-backref