Merged
Conversation
talum
force-pushed
the
add-attributes-to-footnotes
branch
4 times, most recently
from
e53e483 to
424136d
Compare
talum
force-pushed
the
add-attributes-to-footnotes
branch
from
424136d to
3e5afd4
Compare
Add data attributes for easier styling within dotcom. Also, add the aria-label for accessibility.
talum
force-pushed
the
add-attributes-to-footnotes
branch
from
3e5afd4 to
b6e462f
Compare
phillmv
changed the base branch from
fix-footnotes-plus-fix-fnref-label-and-backrefs
to
master
phillmv
approved these changes
Sep 16, 2021
Member
phillmv
left a comment
phillmv
left a comment
There was a problem hiding this comment.
Looks good, only static strings were changed, tests pass, straightforward!
|
This commit seems to add a <a href="..." data-footnote-backref="" class="data-footnote-backref" aria-label="Back to content">Perhaps a bug somewhere? I’m guessing the output should be as follows: -<a href="proxy.php?url=..." data-footnote-backref="" class="data-footnote-backref" aria-label="Back to content">
+<a href="proxy.php?url=..." data-footnote-backref="" class="footnote-backref" aria-label="Back to content"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add data attributes for easier styling within dotcom. Also, add the aria-label for accessibility.
Previously, I had added an
<h2>to denote a Footnotes header that could be hidden and was for screenreaders only. We decided we don't need that here. And since we aren't including that here, I dropped thearia-describedbyas well. We'll add those elements to make our rendering more accessible elsewhere.Replaces #233