Expose cmark_node_parent_footnote_def.#254
Merged
phillmv merged 2 commits intogithub:masterfrom Jan 31, 2023
Merged
Conversation
waldyrious
reviewed
Jan 27, 2023
Author
|
Awesome, look forward to getting this merged! Should we rename |
Co-authored-by: Waldir Pimenta <[email protected]>
Member
[^footnote-def]: this is a definitionin contrast to lorem ipsum[^footnote-def].It's consistently in the codebase and I don't really see a compelling reason to rename. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@phillmv in ioquatix@1717040 you introduced a better internal representation for footnotes.
I maintain a fork/interface for Ruby.
We cannot generate the same footnotes as the internal HTML renderer because the public interface doesn't expose all the required details.
This is an attempt to start a discussion around what that interface should look like.
cmark_node_parent_footnote_defseems clunky - what is_defand should this really be part of the name?