Normalize nomenclature: marker row vs. delimiter row#273
Merged
anticomputer merged 1 commit intogithub:masterfrom Jul 20, 2023
waldyrious:marker-vs-delimiter
Merged
Normalize nomenclature: marker row vs. delimiter row#273anticomputer merged 1 commit intogithub:masterfrom waldyrious:marker-vs-delimiter
anticomputer merged 1 commit intogithub:masterfrom
waldyrious:marker-vs-delimiter
Conversation
The code for the table extension used the term 'marker row', but the spec calls it 'delimiter row'. This change normalizes the terminology so that it's consistent.
Author
|
Note: some of the changes the original commit f8dd3e0 conflicted with some of the changes from 78e3f1d. I have now updated the branch to resolve the conflict. |
Author
|
As I've been seeing regular recent activity in the repo, and given this PR has been open for several months now, I thought I'd ping the people who have been pushing commits recently, for feedback on whether (and when, if so) this change will be considered: @phillmv, @anticomputer, @kevinbackhouse. I'd appreciate any input! |
|
I'm from the security team, and all of my activity has been bug-fixing. I have no opinion on this marker-vs-delimiter naming question. The code change looks harmless to me, so I'm fine with approving it if people think it's important. |
kevinbackhouse
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for the table extension used the term "marker row" for the line separating a table header from the body, but the spec calls it "delimiter row". This change normalizes the terminology in the code so that it's consistent with the spec.
This PR addresses issue #269.