Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the git.PlainOpenWithOptions function to properly handle worktrees by enabling the use of the dotGitCommonDir filesystem when a worktree's commondir file is detected, even when EnableDotGitCommonDir is not explicitly set in options.
- Modifies the condition for using
dotgit.NewRepositoryFilesystemto check for both the option flag and the presence of a common directory - Moves the
dotGitCommonvariable declaration to be available regardless of the option setting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
noahfraiture
force-pushed
the
worktree
branch
from
fafadb5 to
82e8f4a
Compare
Member
|
|
Member
|
I'm not sure we need this change. Users can reach the same outcome by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the
git.PlainOpenWithOptionswhen opening a worktree. Previously the err "no reference found" were returned.