all: replace all usages of golang.org/x/sys/execabs with os/exec by thaJeztah · Pull Request #455 · golang/tools

thaJeztah · 2023-11-01T23:48:03Z

The "golang.org/x/sys/execabs" package was introduced to address a
security issue on Windows, and changing the default behavior of os/exec
was considered a breaking change. go1.19 applied the behavior that was
previously implemented in the execabs package through CL 403274.

This reverts fe37c9e (CL 284773).
Updates #43724.

gopherbot · 2023-11-01T23:59:13Z

This PR (HEAD: 55f0463) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/539017.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-02T00:05:29Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T00:18:07Z

Message from Sebastiaan van Stijn:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T17:07:49Z

Message from Bryan Mills:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

The "golang.org/x/sys/execabs" package was introduced to address a security issue on Windows, and changing the default behavior of os/exec was considered a breaking change. go1.19 applied the behavior that was previously implemented in the execabs package through CL 403274. This reverts fe37c9e (CL 284773). Updates #43724. Signed-off-by: Sebastiaan van Stijn <[email protected]>

gopherbot · 2023-11-09T08:30:31Z

This PR (HEAD: 18e93f3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/539017.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-09T08:36:58Z

Message from Sebastiaan van Stijn:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T10:20:55Z

Message from Sebastiaan van Stijn:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T15:48:11Z

Message from Bryan Mills:

Patch Set 3: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T15:55:09Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-09T15:37:06Z","revision":"14807c5aa12bdb43f3fad0fc765fd80a7f79b52e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T16:01:56Z

Message from Bryan Mills:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T16:01:57Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T16:01:59Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T17:31:07Z

Message from Roland Shoemaker:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/539017.
After addressing review feedback, remember to publish your drafts!

The "golang.org/x/sys/execabs" package was introduced to address a security issue on Windows, and changing the default behavior of os/exec was considered a breaking change. go1.19 applied the behavior that was previously implemented in the execabs package through CL 403274. This reverts fe37c9e (CL 284773). Updates #43724. Change-Id: I53987d0d0009b8dd11e05fc3d17cbffb9625a9c1 GitHub-Last-Rev: 18e93f3 GitHub-Pull-Request: #455 Reviewed-on: https://go-review.googlesource.com/c/tools/+/539017 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Commit-Queue: Bryan Mills <[email protected]>

gopherbot · 2023-11-09T20:17:49Z

This PR is being closed because golang.org/cl/539017 has been merged.

The "golang.org/x/sys/execabs" package was introduced to address a security issue on Windows, and changing the default behavior of os/exec was considered a breaking change. go1.19 applied the behavior that was previously implemented in the execabs package through CL 403274. This reverts 7b1be56 (CL 284773). Updates #43724. Change-Id: I53987d0d0009b8dd11e05fc3d17cbffb9625a9c1 GitHub-Last-Rev: 18e93f39c4e539c28166d4e29a58bbe0eb5711e7 GitHub-Pull-Request: golang/tools#455 Reviewed-on: https://go-review.googlesource.com/c/tools/+/539017 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Commit-Queue: Bryan Mills <[email protected]>

The "golang.org/x/sys/execabs" package was introduced to address a security issue on Windows, and changing the default behavior of os/exec was considered a breaking change. go1.19 applied the behavior that was previously implemented in the execabs package through CL 403274. This reverts 9be453e (CL 284773). Updates #43724. Change-Id: I53987d0d0009b8dd11e05fc3d17cbffb9625a9c1 GitHub-Last-Rev: 18e93f39c4e539c28166d4e29a58bbe0eb5711e7 GitHub-Pull-Request: golang/tools#455 Reviewed-on: https://go-review.googlesource.com/c/tools/+/539017 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Commit-Queue: Bryan Mills <[email protected]>

thaJeztah mentioned this pull request Nov 1, 2023

switch back from golang.org/x/sys/execabs to os/exec (go1.19) containerd/containerd#7647

Merged

thaJeztah force-pushed the no_execabs branch from 55f0463 to 18e93f3 Compare November 9, 2023 08:25

gopherbot closed this Nov 9, 2023

thaJeztah deleted the no_execabs branch November 9, 2023 21:10

Conversation

thaJeztah commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Nov 1, 2023

Uh oh!

gopherbot commented Nov 2, 2023

Uh oh!

gopherbot commented Nov 2, 2023

Uh oh!

gopherbot commented Nov 8, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

gopherbot commented Nov 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thaJeztah commented Nov 1, 2023 •

edited

Loading