Increase the max animation delay for App Check#347
Merged
mdmathias merged 1 commit intomdmathias/app-attestfrom Nov 3, 2023
Merged
Increase the max animation delay for App Check#347mdmathias merged 1 commit intomdmathias/app-attestfrom
mdmathias merged 1 commit intomdmathias/app-attestfrom
Conversation
While we ask that developers pre-warm their apps to use App Check (i.e., generate the key and attestation object), we will still need to generate the assertion and execute a round trip with the backend to get the token sent with the sign in request. Testing on a real device shows that this averages somewhere within the range of approximate 0.6s to 1.0s.
yalkhder
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we ask that developers pre-warm their apps to use App Check (i.e., generate the key and attestation object), we will still need to generate the assertion and execute a round trip with the backend to get the token sent with the sign in request. Testing on a real device shows that this averages somewhere within the range of approximate 0.6s to 1.0s.