Skip to content

[App Attest] Reset App Attest key state if 'DCErrorInvalidInput' occurs#54

Merged
ncooke3 merged 2 commits intomainfrom
nc/invalid-input
May 9, 2024
Merged

[App Attest] Reset App Attest key state if 'DCErrorInvalidInput' occurs#54
ncooke3 merged 2 commits intomainfrom
nc/invalid-input

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 9, 2024

@ncooke3
Copy link
Member Author

ncooke3 commented May 9, 2024

I cannot repro the CI failure locally. @andrewheard, have you seen the exponential test flake before when working in this repo?

@ncooke3
Copy link
Member Author

ncooke3 commented May 9, 2024

I cannot repro the CI failure locally. @andrewheard, have you seen the exponential test flake before when working in this repo?

I opened a PR with no code changes and see that those wrapper tests are indeed failing on main: https://github.com/google/app-check/actions/runs/9021053830/job/24787505087?pr=56

Probably has something to do with new macOS runners

@ncooke3 ncooke3 requested review from andrewheard and paulb777 May 9, 2024 17:40
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to be in this PR, but how about disabling the failing test with an issue.

@ncooke3 ncooke3 merged commit 9c29eed into main May 9, 2024
@ncooke3 ncooke3 deleted the nc/invalid-input branch May 9, 2024 18:38
@andrewheard
Copy link
Collaborator

I cannot repro the CI failure locally. @andrewheard, have you seen the exponential test flake before when working in this repo?

I opened a PR with no code changes and see that those wrapper tests are indeed failing on main: google/app-check/actions/runs/9021053830/job/24787505087?pr=56

Probably has something to do with new macOS runners

Thanks for checking on main, @ncooke3 . I don't recall them failing before but it has been quite a while.

@ncooke3
Copy link
Member Author

ncooke3 commented May 9, 2024

Sounds good. As Paul suggested, I'll disable and file an issue. I tried varying the timeout period to see if there was a sweet spot that would work in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppCheck + AppAttest getAppCheckToken failing for 10% of users in production

3 participants