Merged
Conversation
dmah42
previously approved these changes
Oct 10, 2023
… builds Trusted publishing has been available since v1.8.0 of the pypa-publish action. It enables password-less authentication and wheel uploads from the wheel upload job. `cibuildwheel` was bumped to v2.16.2 to allow Python 3.12 wheel builds. More info on trusted publishing: https://github.com/marketplace/actions/pypi-publish#trusted-publishing The Windows distribution was reverted to `latest` in the OS matrix, since the discovery problem of MSVC was fixed in a Bazel patch release.
nicholasjng
force-pushed
the
python312-support
branch
from
609415e to
14a2530
Compare
Contributor
Author
|
Rebased on |
dmah42
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits contain a few changes:
checkoutto v4, reset towindows-latestas Windows runner image. (609415e)cibuildwheelversion bump and envvar change. (609415e)Related: I am currently working on a project using
setuptools_scmas an addition in the build step, which makes manual version bumping for the Python bindings unnecessary (the package parses the new version out of a tag name created e.g. by a GitHub release), in case there is interest in opting into that.