Closed
Conversation
This was referenced Jul 6, 2022
Collaborator
|
so I can merge this but I'm not familiar with the MS STL... can you add something to our CI too to prevent regression? I would have thought this should have been caught by our "CI / Build Windows 2019" test some time ago. Perhaps the CI needs to also be invoked with the flags you mention? |
Collaborator
|
Also did you consider the solution mentioned in #6898 (comment)? |
Author
|
This just fixes a minor inconvenience with VS 2022 where flatbuffers implicitly assumes that I don't have the cycles to look into the CI at the moment, so closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small inconsistency when using flatbuffers headers with different cpp runtimes.
With the
--cpp-std c++17and--cpp-static-reflectionoptions, the C++ generator emitsstd::arrayfields as part of the reflection data. When using LLVM's STL,flatbuffers.hhappens to implicitly includearrayviaspan, but the MS STL forward declaresarrayinspan, and so it needs to be included separately.(Resolves one of the issues in #6898)