Fix verification for C# unions#7970
Merged
le-michael merged 9 commits intogoogle:masterfrom Oct 1, 2023
CurtHagenlocher:FixEnumVerify
Merged
Fix verification for C# unions#7970le-michael merged 9 commits intogoogle:masterfrom CurtHagenlocher:FixEnumVerify
le-michael merged 9 commits intogoogle:masterfrom
CurtHagenlocher:FixEnumVerify
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
This pull request is stale because it has been open 3 weeks with no activity. Please comment or label |
… into FixEnumVerify
…atbuffers into FixEnumVerify
CurtHagenlocher
changed the title
monolith-jaehoon
added a commit
to monolith-jaehoon/flatbuffers
that referenced
this pull request
Jul 17, 2023
Contributor
Author
|
Yes, that's right. The other commits were just porting changes from the main branch. |
|
Any updates on this? |
Contributor
|
Thanks for the fix. Seems like something the CI should have caught... |
le-michael
approved these changes
Oct 1, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Fix verification for unions * Run scripts\generate_code.py --------- Co-authored-by: Michael Le <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Fix verification for unions * Run scripts\generate_code.py --------- Co-authored-by: Michael Le <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current compiler produces incorrect code (see #7899) for verifying unions when the object API isn't generated. This fixes that.
Also fixes the C# Desktop framework project to build and run correctly.