Small optimization on "deserialization" and fix on benchmarks again#7982
Merged
dbaileychess merged 3 commits intogoogle:masterfrom May 31, 2023
Merged
Small optimization on "deserialization" and fix on benchmarks again#7982dbaileychess merged 3 commits intogoogle:masterfrom
dbaileychess merged 3 commits intogoogle:masterfrom
Conversation
Commit 6e214c3 fixes Kotlin build, but makes the kotlin-benchmark plugin misses the java classes at runtime, causing NotClassFoundError. The alternative to solve the issue is to read java's pom.xml to get the latest java version and use it as dependency. With that we avoid compilation errors on a new version and keep benchmark plugin happy.
github-actions
bot
added
c++
codegen
Contributor
Author
jvm summary:
Benchmark Mode Cnt Score Error Units
FlatbufferBenchmark.monstersDeserializationJava avgt 5 60202904,433 ± 2571267,473 ns/op
FlatbufferBenchmark.monstersDeserializationKotlin avgt 5 63491321,720 ± 582610,015 ns/op
FlatbufferBenchmark.monstersSerializationJava avgt 5 43302673,950 ± 195710,100 ns/op
FlatbufferBenchmark.monstersSerializationKotlin avgt 5 46153101,229 ± 87102,836 ns/opThis is the latest from benchmark, for some reason a couple of commits were missing for #7969 although it was pushed 🤷 |
dbaileychess
approved these changes
May 31, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…oogle#7982) * [Kotlin] Small optimizations and benchmark on deserialization * [Kotlin] Remove redudant assign() method (use init() instead) * [Kotlin] Fix benchmark run after change in flatbuffers-java deps Commit 6e214c3 fixes Kotlin build, but makes the kotlin-benchmark plugin misses the java classes at runtime, causing NotClassFoundError. The alternative to solve the issue is to read java's pom.xml to get the latest java version and use it as dependency. With that we avoid compilation errors on a new version and keep benchmark plugin happy.
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…oogle#7982) * [Kotlin] Small optimizations and benchmark on deserialization * [Kotlin] Remove redudant assign() method (use init() instead) * [Kotlin] Fix benchmark run after change in flatbuffers-java deps Commit 6e214c3 fixes Kotlin build, but makes the kotlin-benchmark plugin misses the java classes at runtime, causing NotClassFoundError. The alternative to solve the issue is to read java's pom.xml to get the latest java version and use it as dependency. With that we avoid compilation errors on a new version and keep benchmark plugin happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 6e214c3 fixes Kotlin build,
but makes the kotlin-benchmark plugin misses the java classes at
runtime, causing NotClassFoundError. The alternative to solve the issue
is to read java's pom.xml to get the latest java version and use it
as dependency. With that we avoid compilation errors on a new version and
keep benchmark plugin happy.